On Wed, Jul 08, 2020 at 09:10:36AM -0700, William Tu wrote: > The patch adds VxLAN encap tc-offload support. The userspace datapath, > dpif-netdev, > flow format differs than the kernel datapath in case of tunnel encap. Unlike > kernel, > the dpif-netdev does not use set and output action, but uses a single clone > action with > all the tunnel info nested inside. As an exmaple blow: > actions:clone(tnl_push(tnl_port(5), > > header(size=50,type=4,eth(dst=06:1d:6e:a3:f1:61,src=26:df:25:f6:7b:4f,dl_type=0x0800), > ipv4(src=172.31.1.100,dst=172.31.1.1,proto=17,tos=0,ttl=64,frag=0x4000), > udp(src=0,dst=4789,csum=0x0), > vxlan(flags=0x8000000,vni=0x0)),out_port(2) > ), 3) > > The patch parses the above tunnel encap format and passes to > the tc for offloading the VxLAN tunnel. > > Example of tc format: > $ tc -s filter show dev ovs-p1 ingress > filter protocol ip pref 3 flower chain 0 > filter protocol ip pref 3 flower chain 0 handle 0x1 > dst_mac 56:2a:1f:3c:bb:f2 > src_mac 96:0c:a7:b0:60:a4 > eth_type ipv4 > ip_tos 0/0x3 > ip_flags nofrag > skip_hw > not_in_hw > action order 1: tunnel_key set > src_ip 172.31.1.100 > dst_ip 172.31.1.1 > key_id 0 > dst_port 4789 > nocsum > ttl 64 pipe > index 2 ref 1 bind 1 installed 0 sec used 0 sec > Action statistics: > Sent 168 bytes 2 pkt (dropped 0, overlimits 0 requeues 0) > backlog 0b 0p requeues 0 > no_percpu > > action order 2: mirred (Egress Redirect to device ovs-p0) stolen > index 2 ref 1 bind 1 installed 0 sec used 0 sec > Action statistics: > Sent 168 bytes 2 pkt (dropped 0, overlimits 0 requeues 0) > backlog 0b 0p requeues 0 > cookie b46e99079448ce581d0fe7a9853c0bb5 > no_percpu > > Signed-off-by: William Tu <[email protected]>
Hi William, all, I'm a little unclear on the history of this patchset [1]. But it seems to me that while patches 1/2 and 2/3 were applied as: * 48c1ab5d74ec netdev: Allow storing dpif type into netdev structure. * 8842fdf1b318 netdev-offload: Use dpif type instead of class. This patch was not. As we are now getting towards it's third birthday I'm going to declare it stale and mark it as Changes Requested in patchwork. [1] https://mail.openvswitch.org/pipermail/ovs-dev/2020-July/372699.html _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
