On 25/06/2023 7:04, Gavin Li wrote: > > On 6/23/2023 7:06 PM, Simon Horman wrote: >> External email: Use caution opening links or attachments >> >> >> On Fri, Jun 23, 2023 at 01:01:38PM +0200, Eelco Chaudron wrote: >>> >>> On 23 Jun 2023, at 12:57, Simon Horman wrote: >>> >>>> On Fri, Jun 23, 2023 at 11:16:50AM +0200, Eelco Chaudron wrote: >>>>> >>>>> On 19 Jun 2023, at 13:56, Roi Dayan wrote: >>>>> >>>>>> From: Gavin Li <[email protected]> >>>>>> >>>>>> Add a vxlan gbp offload test case: >>>>>> >>>>>> vxlan offloads with gbp extention - ping between two ports - offloads >>>>>> enabled ok >>>>>> >>>>>> Signed-off-by: Gavin Li <[email protected]> >>>>>> Reviewed-by: Roi Dayan <[email protected]> >>>>>> Reviewed-by: Simon Horman <[email protected]> >>>>>> --- >>>>> Thanks for adding the test, however, there is one problem. If the kernel >>>>> does not support this feature the test is not skipped but errors out. >>>>> >>>>> I’ve added some comments inline below. >>>> Hi Eelco, >>>> >>>> I take it that this means we would like to see a v6? >>> Yes, when I looked at this briefly I thought we should be good with v5 and >>> the nits. But then I tested this without kernel support. >> Ack, I've marked it as changes requested in patchwork. >> >> Roi, sorry to have to ask for v6 but >> I think we are pretty close on this one. > ACK
thanks for all the review! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
