Ok, thanks for the clarification. I will modify and send this patch again by another email named as gangyewei. ---- Simon Jones
Ilya Maximets <[email protected]> 于2023年6月29日周四 22:55写道： > On 6/28/23 03:12, Simon Jones wrote: > > This patch is same as MR: https://github.com/openvswitch/ovs/pull/415 > > > > ---- This is Patch detail ---- > > > > From ddff9ac664083e6cbed97c214935b77f25dd1228 Mon Sep 17 00:00:00 2001 > > From: simon <[email protected]> > > Date: Tue, 27 Jun 2023 11:20:51 +0800 > > Subject: [PATCH V3] Bugfix of ovs-tcpdump. > > > > This bug will cause megaflow action wrong. > > For detail discuss, refer email of ovs-discuss titled in "[BUG] > > [ovs-tcpdump] Got duplicate ...". > > Hi, thanks for the patch! > > Please, include the actual description of the issue in the commit > message itself. It should be possible to understand the issue > without looking at the external resources. > > Also, patches should contain a Signed-off-by tag in a following format: > > Signed-off-by: Firstname Lastname <[email protected]> > > Here is what the contribution guide says about this: > > Q: What's a Signed-off-by and how do I provide one? > > A: Free and open source software projects usually require a > contributor to > provide some assurance that they're entitled to contribute the code > that > they provide. Some projects, for example, do this with a Contributor > License Agreement (CLA) or a copyright assignment that is signed on > paper > or electronically. > > For this purpose, Open vSwitch has adopted something called the > Developer's > Certificate of Origin (DCO), which is also used by the Linux kernel and > originated there. Informally stated, agreeing to the DCO is the > developer's way of attesting that a particular commit that they are > contributing is one that they are allowed to contribute. You should > visit > https://developercertificate.org/ to read the full statement of the > DCO, > which is less than 200 words long. > > To certify compliance with the Developer's Certificate of Origin for a > particular commit, just add the following line to the end of your > commit > message, properly substituting your name and email address: > > Signed-off-by: Firstname Lastname <[email protected]> > > Git has special support for adding a Signed-off-by line to a commit > message: when you run "git commit", just add the -s option, as in "git > commit -s". If you use the "git citool" GUI for commits, you can add a > Signed-off-by line to the commit message by pressing Control+S. Other > Git > user interfaces may provide similar support. > > Best regards, Ilya Maximets. > > > --- > > utilities/ovs-tcpdump.in | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in > > index 420c11eb8..4cbd9a5d3 100755 > > --- a/utilities/ovs-tcpdump.in > > +++ b/utilities/ovs-tcpdump.in > > @@ -96,6 +96,10 @@ def _install_dst_if_linux(tap_name, mtu_value=None): > > *(['ip', 'link', 'set', 'dev', str(tap_name), 'up'])) > > pipe.wait() > > > > + pipe = _doexec( > > + *(['ip', '-6', 'addr', 'flush', 'dev', str(tap_name)])) > > + pipe.wait() > > + > > > > def _remove_dst_if_linux(tap_name): > > _doexec( > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
