On 7/13/23 11:26, Viacheslav Galaktionov via dev wrote: > Currently, if the user wants to track related connections, they have to > specify a helper in all CT actions, which contradicts the behaviour > described in the documentation. > > Fix this by using the helper committed along with the connection whenever > a given CT action does not specify a helper of its own. > > Signed-off-by: Viacheslav Galaktionov <[email protected]> > Acked-by: Ivan Malov <[email protected]> > --- > lib/conntrack.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/conntrack.c b/lib/conntrack.c > index 4375c03e2..d505ffed1 100644 > --- a/lib/conntrack.c > +++ b/lib/conntrack.c > @@ -1323,6 +1323,10 @@ process_one(struct conntrack *ct, struct dp_packet > *pkt, > } > } > > + if (conn && helper == NULL) { > + helper = conn->alg; > + } > +
Hi, Viacheslav. Thanks for the fix! We have tests in the system-traffic-userspace testsuite that should cover use of alg for FTP, for example. Do you know why they are not triggering the issue? Could you add a test that demonstrates it? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
