On 7/14/23 17:17, Lorenzo Bianconi wrote:
>> It's specified in RFC 8415. This also avoids having to free/realloc the
>> pfd->uuid.data memory. That part was not correct anyway and was flagged
>> by ASAN as a memleak:
>>
>> Direct leak of 42 byte(s) in 3 object(s) allocated from:
>> #0 0x55e5b6354c9e in malloc
>> (/workspace/ovn-tmp/controller/ovn-controller+0x2edc9e) (BuildId:
>> f963f8c756bd5a2207a9b3c922d4362e46bb3162)
>> #1 0x55e5b671878d in xmalloc__ /workspace/ovn-tmp/ovs/lib/util.c:140:15
>> #2 0x55e5b671878d in xmalloc /workspace/ovn-tmp/ovs/lib/util.c:175:12
>> #3 0x55e5b642cebc in pinctrl_parse_dhcpv6_reply
>> /workspace/ovn-tmp/controller/pinctrl.c:997:20
>> #4 0x55e5b642cebc in pinctrl_handle_dhcp6_server
>> /workspace/ovn-tmp/controller/pinctrl.c:1040:9
>> #5 0x55e5b642cebc in process_packet_in
>> /workspace/ovn-tmp/controller/pinctrl.c:3210:9
>> #6 0x55e5b642cebc in pinctrl_recv
>> /workspace/ovn-tmp/controller/pinctrl.c:3290:9
>> #7 0x55e5b642cebc in pinctrl_handler
>> /workspace/ovn-tmp/controller/pinctrl.c:3385:17
>> #8 0x55e5b66ef664 in ovsthread_wrapper
>> /workspace/ovn-tmp/ovs/lib/ovs-thread.c:423:12
>> #9 0x7faa30194b42 (/lib/x86_64-linux-gnu/libc.so.6+0x94b42) (BuildId:
>> 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
>>
>> Fixes: faa44a0c60a3 ("controller: IPv6 Prefix-Delegation: introduce
>> RENEW/REBIND msg support")
>> Signed-off-by: Dumitru Ceara <[email protected]>
>> ---
>> controller/pinctrl.c | 33 ++++++++++++++++-----------------
>> 1 file changed, 16 insertions(+), 17 deletions(-)
>
> thx for fixing it.
>
> Acked-by: Lorenzo Bianconi <[email protected]>
>
Thanks, Lorenzo and Ales! I applied this to main and to all branches
down to 22.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
