On 7/17/23 11:06, Felix Huettner via dev wrote: > previously it was not possible to set the probe interval for the > connection from a relay to the backing ovsdb-server. With this change it > is now possible using the > `ovsdb-server/set-relay-source-probe-interval` command. > > Reviewed-by: Simon Horman <simon.hor...@corigine.com> > Signed-off-by: Felix Huettner <felix.huettner@mail.schwarz> > --- > v3: > - use a separate command > - stay with the default of 5sec > > NEWS | 3 +++ > ovsdb/ovsdb-server.c | 30 +++++++++++++++++++++++++++++- > ovsdb/relay.c | 15 ++++++++++++++- > ovsdb/relay.h | 6 +++++- > 4 files changed, 51 insertions(+), 3 deletions(-) >
<snip> > diff --git a/ovsdb/relay.h b/ovsdb/relay.h > index f841554ca..0e7fa1fb8 100644 > --- a/ovsdb/relay.h > +++ b/ovsdb/relay.h > @@ -24,6 +24,8 @@ struct ovsdb; > struct ovsdb_schema; > struct uuid; > > +#define RELAY_SOURCE_DEFAULT_PROBE_INTERVAL 5000 Instead of re-defining the exact number, we should define it as RECONNECT_DEFAULT_PROBE_INTERVAL. It's the same, but we'll not need to maintain the number in two places. In order to save the extra iteration for small changes, I made the change above, fixed a couple of style issues and applied the patch. Thanks! Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
