On 7/19/23 13:58, Eelco Chaudron wrote:
>
>
> On 19 Jul 2023, at 12:33, Ilya Maximets wrote:
>
>> In a backtrace test with monitor the child process will be re-started
>> after being killed. The test doesn't wait for that to happen, so it
>> is possible that during the test cleanup the pid in a pid file is not
>> updated yet. Hence, the on-exit hook will not kill the process.
>>
>> This is causing issues in Cirrus CI, because gmake on FreBSD waits for
>> all child processes to exit and that never happens.
>>
>> Fix the issue by waiting for a new process. It's also better to exit
>> gracefully instead of relying on the on-exit kill.
>>
>> Fixes: 759a29dc2d97 ("backtrace: Extend the backtrace functionality.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> This looks good to me. Thanks for digging into this it will save on the
> manual re-runs ;)
>
> Acked-by: Eelco Chaudron <[email protected]>
>
Thanks, Ales and Eelco!
Applied and backported to 3.2.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
