On Thu, Jul 20, 2023 at 11:38:41AM -0400, Aaron Conole wrote: > Hi Simon, > > Thanks for the contribution! > > Simon Jones <[email protected]> writes: > > > From: simon <[email protected]> > > > > Fix bug of ovs-tcpdump, which will cause megaflow action wrong. > > > > As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address by > > default. > > This is true only on systems where the ipv6 autoconf sysctl is set to > true, I think. I think it is probably worth including that detail. > > > For vxlan topology, mipxxx will be treated as tunnel port, and will got > > error actions. > > > > For detail discuss, refer: > > https://github.com/batmancn/github-work/blob/main/ovs-bugfix-ovs-tcpdump.md > > Why not include some of these details in the commit message? At least, > we can say that ipv6 packets going down the mirror port will cause > erroneous behavior in most scenarios, and we should just stop ipv6 > address there. > > Actually, I wonder if there should be any other steps we might need to > take incase zeroconf is setup for ipv4 on the system, but hopefully that > is managed separately.
Hi Simon, could I ask you to prepare a v3 taking into account Arron's suggestion. > > Signed-off-by: simon <[email protected]> And updating the above to include your first and last name, as appears in the from address of your emails. > > --- > > Acked-by: Aaron Conole <[email protected]> You can include this in v3, immediately after your Signed-off-by line. Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
