Actually I meet the problem with IPIP. The IGMP/UDPLITE/SCTP are added because they are supported in tc csum action now.
From: Simon Horman <[email protected]> Date: 2023-08-04 23:33:43 To: Faicker Mo <[email protected]> Cc: [email protected],[email protected] Subject: Re: [ovs-dev] [PATCH v2 1/2] netdev-tc-offload: Add csum offload of protocols IGMP/UDPLITE/SCTP>On Wed, Aug 02, 2023 at 04:59:35PM +0800, Faicker Mo via dev wrote: >> Add tc csum offload support of protocols IGMP/UDPLITE/SCTP >> >> Signed-off-by: Faicker Mo <[email protected]> > >UDPLite will be deprecated in the Linux kernel from v6.4 [1]. >Are you sure that we want to increase it's support in OvS at this time? > >[1] https://lore.kernel.org/netdev/[email protected]/ > >Moreover, please include some motivation - the why - in the patch description. > >> --- >> lib/tc.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/lib/tc.c b/lib/tc.c >> index f49048cda..52a74d9d0 100644 >> --- a/lib/tc.c >> +++ b/lib/tc.c >> @@ -2978,6 +2978,15 @@ csum_update_flag(struct tc_flower *flower, >> } else if (flower->key.ip_proto == IPPROTO_ICMPV6) { >> flower->needs_full_ip_proto_mask = true; >> flower->csum_update_flags |= TCA_CSUM_UPDATE_FLAG_ICMP; >> + } else if (flower->key.ip_proto == IPPROTO_IGMP) { >> + flower->needs_full_ip_proto_mask = true; >> + flower->csum_update_flags |= TCA_CSUM_UPDATE_FLAG_IGMP; >> + } else if (flower->key.ip_proto == IPPROTO_UDPLITE) { >> + flower->needs_full_ip_proto_mask = true; >> + flower->csum_update_flags |= TCA_CSUM_UPDATE_FLAG_UDPLITE; >> + } else if (flower->key.ip_proto == IPPROTO_SCTP) { >> + flower->needs_full_ip_proto_mask = true; >> + flower->csum_update_flags |= TCA_CSUM_UPDATE_FLAG_SCTP; >> } else { >> VLOG_WARN_RL(&error_rl, >> "can't offload rewrite of IP/IPV6 with ip_proto: >> %d", >> -- >> 2.39.3 >> >> >> >> >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
