On Tue, Aug 15, 2023 at 09:40:50AM +0200, Eelco Chaudron wrote: > > > On 27 Jul 2023, at 12:53, Ilya Maximets wrote: > > > On 7/27/23 04:16, Peng He wrote: > >> > >> > >> Simon Horman <simon.hor...@corigine.com > >> <mailto:simon.hor...@corigine.com>> 于2023年7月27日周四 01:04写道： > >> > >> On Thu, Jul 06, 2023 at 04:59:36PM +0800, Peng He wrote: > >> > >> ... > >> > >> > >>>> +dnl Replace OpenFlow rules, trigger revalidation and wait for > >> it to > >> > >>> complete. > >> > >>>> +AT_CHECK([echo 'table=0,in_port=p1,ip actions=ct(commit)' | > >> ovs-ofctl > >> > >>> --bundle replace-flows br0 -]) > >> > >>>> +AT_CHECK([ovs-appctl revalidator/wait]) > >> > >>>> + > >> > >>>> +dnl Inconsistent ukey should be deleted. > >> > >>>> +AT_CHECK([ovs-appctl upcall/show | grep keys | grep -q -v 0], > >> [1]) > >> > >>>> + > >> > >>>> +dnl Check the log for the flow modification error. > >> > >>>> +AT_CHECK([grep -q -E ".*failed to put.*$" ovs-vswitchd.log]) > >> > >>>> + > >> > >>>> +dnl Remove warning logs to let test suite pass. > >> > >>>> +OVS_VSWITCHD_STOP(["dnl > >> > >>>> +/.*failed to put.*$/d > >> > >>>> +/.*failed to flow_del.*$/d"]) > >> > >>> > >> > >>> You missed the indentation suggested by Ilya: > >> > >>> > >> > >>> > >> > >> Which kind of the email client are you using... > >> > >> The indentation here is really easy to miss.... > >> > > > >> > > From the User-Agent data, he seems to be using > >> Thunderbird/102.10.0 but the emails are plain text, so the problem is > >> probably with your email client converting them to “html” like format. If > >> you can configure a fixed width font for text emails you might spot these > >> thinks easier. > >> > > >> > > >> > I change to use another email client now, thanks ! > >> > >> Hi Peng He, all, > >> > >> Am I correct in assuming that there will be a v13? > >> > >> > >> Hi, if need, I can submit a v13, the current version is just missing some > >> indentation. > >> > >> "The changes look good, with one little nit (see below), but those can be > >> applied during commit." > >> I thought it would be changed by the maintainer during merging... > > > > My impression was that Eelco was generally happy with the patch, > > and the small indentation fix for a test can be applied on commit. > > > > But Eelco is on PTO for now, and I didn't get to review that patch > > myself yet in order to accept it. > > Hi Simon/Peng, > > Sorry for the confusion :) I’m back from PTO, and I can apply the patch, > unless Simon has some objections?
Thanks Eelco, No objection from my side. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
