On Tue, Aug 22, 2023 at 4:11 AM David Marchand <[email protected]> wrote: > > OVS current sets RTE_MBUF_F_TX_IPV[46] flags in early stages of the > packet reception and keeps track of the IP packet type as the packet > goes through OVS pipeline. > When a packet leaves OVS and hits a DPDK driver, OVS may not request IP > checksum offloading but leaves one of this packet type flag in ol_flags. > > Setting RTE_MBUF_F_TX_IPV4 without RTE_MBUF_F_TX_IPSUM is not defined > in the DPDK api. This can confuse some drivers (like net/iavf) which > then reads zero'd l2_len and l3_len and ends up dropping the packet. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2231081 > Fixes: 5d11c47d3ebe ("userspace: Enable IP checksum offloading by default.") > Signed-off-by: David Marchand <[email protected]> > --- > Some note: > - I submitted a fix on the DPDK side for net/iavf. But to be on the safe > side, this OVS patch here is a proposal to avoid hitting bugs in some > other drivers, >
I didn't test this thoroughly. But the documentation says that these flags are only required if checksum/TSO is requested. Acked-by: Mike Pattrick <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
