On 24 Aug 2023, at 17:19, David Marchand wrote:
> As reported by Ales when doing some OVN integration tests with OVS 3.2, > net/tap has broken L4 checksum offloads. > > Fixes are pending on DPDK side. > Until they get in a LTS release used by OVS, disable those Tx offloads. > > Signed-off-by: David Marchand <[email protected]> Thanks for the patch, this one looks good to me, and tested it in combination with the ‘dpdk test patch series’. Acked-by: Eelco Chaudron <[email protected]> > --- > lib/netdev-dpdk.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 8f1361e21f..fc7225cba1 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -1312,6 +1312,14 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) > dev->hw_ol_features &= ~NETDEV_RX_HW_SCATTER; > } > > + if (!strcmp(info.driver_name, "net_tap")) { > + VLOG_WARN("%s: disabled Tx L4 checksum offloads for a net/tap port.", > + netdev_get_name(&dev->up)); > + info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_UDP_CKSUM; > + info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > + info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_TSO; > + } > + > if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) { > dev->hw_ol_features |= NETDEV_TX_IPV4_CKSUM_OFFLOAD; > } else { > -- > 2.41.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
