On 8/17/23 02:30, Antonin Bas wrote: > From: Antonin Bas <[email protected]> > > From: Antonin Bas <[email protected]> > > Since Open vSwitch 2.7, the max_len option has no effect, and the full > packet is always sent to controllers. This was confirmed with both the > kernel and netdev datapaths.
Hi, Antonin. Thanks for the patch! And sorry for delay. IIUC, this also affects the output(port=controller,max_len=X) actions, right? In this case, we need to update the docs for the 'output' action as well. Best regards, Ilya Maximets. > > Reported-by: Antonin Bas <[email protected]> > Reported-at: https://github.com/openvswitch/ovs-issues/issues/295 > Signed-off-by: Antonin Bas <[email protected]> > --- > v2: Fix typos, set author to VMware email address > --- > Documentation/ref/ovs-actions.7.rst | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ref/ovs-actions.7.rst > b/Documentation/ref/ovs-actions.7.rst > index d13895655..36adcc5db 100644 > --- a/Documentation/ref/ovs-actions.7.rst > +++ b/Documentation/ref/ovs-actions.7.rst > @@ -694,7 +694,8 @@ encapsulated in an OpenFlow ``packet-in`` message. The > supported options are: > Limit to *max_len* the number of bytes of the packet to send in the > ``packet-in.`` A *max_len* of 0 prevents any of the packet from being > sent (thus, only metadata is included). By default, the entire packet is > - sent, equivalent to a *max_len* of 65535. > + sent, equivalent to a *max_len* of 65535. This option has no effect in > + Open vSwith 2.7 and later: the entire packet will always be sent. > > ``reason=``\ *reason* > Specify *reason* as the reason for sending the message in the > @@ -733,6 +734,12 @@ encapsulated in an OpenFlow ``packet-in`` message. The > supported options are: > options require the Open vSwitch ``NXAST_CONTROLLER`` extension action > added > in Open vSwitch 1.6. > > + Open vSwitch 2.7 and later is configured to not buffer packets for the > + packet-in event. As a result, the full packet is always sent to > + controllers. This means that the ``max_len`` option has no effect on the > + ``controller`` action, and all values (even 0) are equivalent to the > default > + value of 65535. > + > > The ``enqueue`` action > ---------------------- _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
