On 2023/09/20 21:32, Ilya Maximets wrote: > On 9/20/23 13:06, Simon Horman wrote: >> On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: >>> A conjunctive flow consists of two or more multiple flows with >>> conjunction actions. When input to the ofproto/trace command >>> matches a conjunctive flow, it outputs flows of all dimensions. >>> >>> Signed-off-by: Nobuhiro MIKI <[email protected]> >> >> Hi Miki-san, >> >> some feedback from my side is provided inline. >> >> >>> diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofproto-dpif.h >>> index d8e0cd37ac5b..32e9048e7167 100644 >>> --- a/ofproto/ofproto-dpif.h >>> +++ b/ofproto/ofproto-dpif.h >>> @@ -103,7 +103,8 @@ struct rule_dpif *rule_dpif_lookup_from_table(struct >>> ofproto_dpif *, >>> ofp_port_t in_port, >>> bool may_packet_in, >>> bool honor_table_miss, >>> - struct xlate_cache *); >>> + struct xlate_cache *, >>> + struct ovs_list *conj_flows); >> >> Perhaps for consistency this should be written as: struct ovs_list *); > > The name is needed, because the type is not descriptive. > > Best regards, Ilya Maximets.
OK. The name 'conj_flows' will remain here. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
