On 9/22/23 14:21, Ilya Maximets wrote:
> If OVN is started less than 30 seconds after system boot, it logs:
> 
>   |memory_trim|WARN|Detected last active timestamp overflow
> 
> The 'now < trim_timeout_ms' is not for a timestamp overflow, but
> for the later subtraction.  'now < last_active_ms' is enough to
> check for the overflow.
> 
> Technically, we shouldn't need to check that now > trim_timeout_ms
> before subtraction, because the result should be a signed integer,
> but it's cleaner this way.
> 
> Fixes: 12ddb1c9d908 ("lflow-cache: Automatically trim cache when it becomes 
> inactive.")
> Signed-off-by: Ilya Maximets <[email protected]>
> ---
> 
> Note: In case of backporting, branches below 23.03 have a bit different code,
>       so the fix will need to be slightly different.
> 

Thanks for the fix, Ilya!

Acked-by: Dumitru Ceara <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to