On Thu, Sep 28, 2023 at 8:28 PM Eelco Chaudron <[email protected]> wrote:
>
> Move stuff in alphabetical order:
>
> #include <config.h>
> #undef NDEBUG
> #include <stdint.h>
> #include <stdio.h>
> #include <string.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include "byteq.h"
> #include "ovstest.h"
> #include "util.h"
>

Sure.

>
> Is there an easy way to report this specific test is skipped on Windows? 
> Maybe break out this test? See lockfile.at for an example.
>

I can split that specific test (`test_byteq_write_read`) into another
function in the `test-byteq.c` file and guard it with an
`AT_SKIP_IF([test "$IS_WIN32" = "yes"])` in `library.at`. Would that
be more acceptable?

Thank you.

Best regards,
James Raphael Tiovalen
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to