On Thu, Sep 28, 2023 at 9:35 AM Simon Horman <[email protected]> wrote:
> On Tue, Sep 26, 2023 at 12:03:51PM +0200, Ales Musil wrote: > > Progpagate the CT limit that is present in the DB into > > datapath. The limit is currently only propagated on change > > and can be overwritten by the dpctl commands. > > > > Signed-off-by: Ales Musil <[email protected]> > > ... > > > @@ -6366,7 +6378,7 @@ handle_flow_mod__(struct ofproto *ofproto, const > struct ofputil_flow_mod *fm, > > error = ofproto_flow_mod_start(ofproto, &ofm); > > if (!error) { > > ofproto_bump_tables_version(ofproto); > > - error = ofproto_flow_mod_finish(ofproto, &ofm, req); > > + error = ofproto_flow_mod_finish(ofproto, &ofm, req); > > Hi Ales, > Hi Simon, thank you for the review. > this hunk appears to be a whitespace change that > is unrelated to the subject of this patch. > Yes that indeed slipped through, it should be fixed in v3. > > > ofmonitor_flush(ofproto->connmgr); > > } > > ovs_mutex_unlock(&ofproto_mutex); > > @@ -8437,7 +8449,7 @@ do_bundle_commit(struct ofconn *ofconn, uint32_t > id, uint16_t flags) > > /* Send error referring to the original message. */ > > ofconn_send_error(ofconn, be->msg, error); > > error = OFPERR_OFPBFC_MSG_FAILED; > > - > > + > > Ditto. > > > /* 2. Revert. Undo all the changes made above. */ > > LIST_FOR_EACH_REVERSE_CONTINUE(be, node, &bundle->msg_list) > { > > if (be->type == OFPTYPE_FLOW_MOD) { > > Also, please add a '.' to the end of the patch subject, > as flagged by the 0-day Robot. > > Other than the above this patch looks good to me. > > Yeah I didn't realize that this new rule is in place, v3 has the dot at the end. Thanks, Ales -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> [email protected] <https://red.ht/sig> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
