On 05.10.23 21:08, Ilya Maximets wrote: > On 10/4/23 14:21, jm...@redhat.com wrote: >> diff --git a/tests/pmd.at b/tests/pmd.at >> index 7bdaca9e7..fb838286b 100644 >> --- a/tests/pmd.at >> +++ b/tests/pmd.at >> @@ -93,11 +93,11 @@ pmd thread numa_id <cleared> core_id <cleared>: >> overhead: NOT AVAIL >> ]) >> >> -AT_CHECK([ovs-appctl dpif/show | sed >> 's/\(tx_queues=\)[[0-9]]*/\1<cleared>/g'], [0], [dnl >> +AT_CHECK([ovs-appctl dpif/show | sed >> 's/\(numa_id=\)[[0-9]]*/\1<cleared>/g'], [0], [dnl > Hi, Jakub. Could you explain what is going on here? > > I'm a bit confused. We cear out the number of tx_queues in some > tests, because it is determined dynamically in the datapath. But > why clearing the numa id instead? The numa id is not changing if > not explicitly set in the port configuration, IIRC. > > Best regards, Ilya Maximets.
True, in pmd.at we use "--dummy-numa" to set the numa sockets and cores. For most cases it is simply 0,0,0,0 or else numa_id is configured so numa_id should be known to us (esp. because netdev-dummy simply stores the numa id internally). I cleared numa_id because the surrounding code does as well and for the sake of testing that the option is printed, it is enough. But if you prefer I will replace <cleared> with specific numa ids in the next patch revision. Best, Jakob _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
