On Sat, Oct 07, 2023 at 06:06:56AM +0000, Li,Rongqing wrote: > > > > -----Original Message----- > > From: Simon Horman <[email protected]> > > Sent: Friday, October 6, 2023 6:52 PM > > To: Li,Rongqing <[email protected]> > > Cc: [email protected] > > Subject: Re: [ovs-dev] [PATCH] netdev: Remove modulo operation in > > dpdk/vhost/afxdp tx path > > > > On Tue, Mar 23, 2021 at 11:51:33AM +0800, Li RongQing wrote: > > > After 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) > > > implementation."), it is impossible that qid is greater than or equal > > > to n_txq of netdev. so remove this modulo operation which is in hot > > > path > > > > > > Signed-off-by: Li RongQing <[email protected]> > > > > Hi Li RongQing, > > > > This patch appears to have gone stale in patchwork, for one reason or > > another. If > > it is still relevant then I think it needs to be revisited, by being > > reposted after > > appropriate preparation. > > > > As such I'm marking this patch as "Deferred" in patchwork. > > > > No action is required unless there is a desire to revisit this patch. > > > I hope this patch can be reviewed > And modulo is an expensive operations in some CPUs, and it is in hot path
Hi Li RongQing, In that case, please consider rebasing and reposting the patch. For one, it does not appear to apply cleanly anymore. For another, this will allow it to run through the upstream CI, AFIK, which was not in place when the patch was originally submitted. Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
