On Tue, Oct 10, 2023 at 5:20 PM Dumitru Ceara <dce...@redhat.com> wrote:
>
> The correct upgrade procedure mentions that databases are upgraded
> at the same time as ovn-northd, so there's nothing that doesn't allow
> northd to write to new columns. The feature flag reports instead what
> features chassis are aware of. In this specific case, if a chassis
> doesn't know how to interpret the 'ls_datapaths' column, ovn-northd
> should set it to NULL and use the deprecated 'datapath' one.
>
> Fixes: ab7a8fe4c018 ("northd: introduce ls_datapath_group column in lb sb db
> table")
> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
> ---
> northd/northd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/northd/northd.c b/northd/northd.c
> index 82c355c982..8424821de1 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -4678,6 +4678,7 @@ sync_lbs(struct ovsdb_idl_txn *ovnsb_txn,
> sbrec_load_balancer_set_datapath_group(sbrec_lb, NULL);
> } else {
> /* datapath_group column is deprecated. */
> + sbrec_load_balancer_set_ls_datapath_group(sbrec_lb, NULL);
> sbrec_load_balancer_set_datapath_group(
> sbrec_lb, lb_dpg ? lb_dpg->dp_group : NULL
> );
> --
> 2.39.3
>
Makes sense, thanks!
Acked-by: Ales Musil <amu...@redhat.com>
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA
amu...@redhat.com
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
