On 10/10/23 17:34, Ilya Maximets wrote: > On 10/10/23 16:27, Ales Musil wrote: >> >> >> On Tue, Oct 10, 2023 at 3:36 PM Dumitru Ceara <dce...@redhat.com >> <mailto:dce...@redhat.com>> wrote: >> >> On 9/26/23 17:18, Lorenzo Bianconi wrote: >> > Introduce lr_datapath_group column in the load_balancer table of the SB >> > db. >> > Sync load_balancers applied to logical_routers to Load_Balancer table >> in >> > the SouthBound database. >> > >> > Reviewed-by: Ales Musil <amu...@redhat.com <mailto:amu...@redhat.com>> >> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2193323 >> <https://bugzilla.redhat.com/show_bug.cgi?id=2193323> >> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com >> <mailto:lorenzo.bianc...@redhat.com>> >> > --- >> >> Thanks, Lorenzo, Ales and Ilya! >> >> We ran this through scale tests internally (ovn-heater and OpenShift) >> and didn't notice a worrying performance hit. I applied the patch to >> main with the following minor changes: >> > > <snip> > >> --- >> >> Regards, >> Dumitru >> >> >> >> Hi Dumitru, >> >> would you mind backporting this series to 23.09 too? This was posted way >> before >> any kind of freeze and it would be very nice to have it in 23.09. > > FWIW, the freeze part is irrelevant because the release have already happened. > > Not saying this feature/bagfix should not be backported, just picking on > words. :) > General considerations regarding potential breaking changes should be applied > here instead. >
The change is backwards compatible (the new column via a feature flag..) and with the follow up fix applied [0] is safe to be backported. I pushed this series to 23.09 too. Thanks, Lorenzo, Ales and Ilya! Regards, Dumitru [0] https://patchwork.ozlabs.org/project/ovn/patch/20231010152020.372098-1-dce...@redhat.com/ _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
