Bleep bloop.  Greetings Jakob Meng, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line lacks whitespace around operator
#100 FILE: lib/command-line.c:82:
        return ovs_cmdl_parse_output_fmt__(arg+9, fmt);

WARNING: Line lacks whitespace around operator
#106 FILE: lib/command-line.c:88:
        return ovs_cmdl_parse_output_fmt__(argv[argi+1], fmt);

WARNING: Line is 80 characters long (recommended limit is 79)
#342 FILE: ofproto/ofproto-dpif.c:6384:
        const struct shash_node **ports = shash_sort(&ofproto->up.port_by_name);

ERROR: Improper whitespace around control block
#375 FILE: ofproto/ofproto-dpif.c:6417:
                SMAP_FOR_EACH(node, &config) {

ERROR: Improper whitespace around control block
#451 FILE: ofproto/ofproto-dpif.c:6538:
        SHASH_FOR_EACH(backer, &all_dpif_backers) {

ERROR: Inappropriate spacing around cast
#475 FILE: ofproto/ofproto-dpif.c:6724:
    unixctl_command_register("dpif/show", "[(-o|--output=)text|json]", 0, 2,

Lines checked: 523, Warnings: 3, Errors: 3


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to