On Tue, Oct 03, 2023 at 03:05:57PM -0400, Aaron Conole wrote: > From: Peng He <hepeng.0...@bytedance.com> > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for both orig and rev directions. This patch introduces a > key_node[CT_DIRS] member as per Aaron's suggestion in the conn which > consists of a key, direction, and a cmap_node for hash lookup so > addressing the feedback received by the original patch [0]. > > With this adjustment, we also remove the assertion that connections in > the table are DEFAULT while updating connection state and/or removing > connections. > > [0] > https://patchwork.ozlabs.org/project/openvswitch/patch/20201129033255.64647-2-hepeng.0...@bytedance.com/ > > [Aaron resolved numerous conflicts due to lack of multiple commits] > > Reported-by: Michael Plato <michael.pl...@tu-berlin.de> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-September/052065.html > Signed-off-by: Peng He <hepeng.0...@bytedance.com> > Co-authored-by: Paolo Valerio <pvale...@redhat.com> > Signed-off-by: Paolo Valerio <pvale...@redhat.com> > Tested-by: Frode Nordahl <frode.nord...@canonical.com> > Acked-by: Ilya Maximets <i.maxim...@ovn.org> > Acked-by: Aaron Conole <acon...@redhat.com> > Signed-off-by: Aaron Conole <acon...@redhat.com> > --- > NOTE: Inserted a check in conn_clean against conn->cleaned, which should > be analagous to the check in post rcu-ified branches for the atomic > test-and-set variable conn->reclaimed
Acked-by: Simon Horman <ho...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
