On 13/10/2023 10:45, Ilya Maximets wrote:
On 10/12/23 14:15, Kevin Traynor wrote:
Add group for dpdkvhostuser(/client) netdev.
Adding as a single group as they display the same status,
one of which is 'mode' to indicate if it's client or server.
Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_status.")
Signed-off-by: Kevin Traynor <ktray...@redhat.com>
---
vswitchd/vswitch.xml | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 1e2a1267d..403b954c2 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -3822,4 +3822,32 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch
options:peer=p1 \
</column>
</group>
+
+ <group title="dpdkvhostuser">
+ <p>
+ dpdkvhostuser and dpdkvhostuserclient
+ netdev specific interface status options.
The 'options' might be not a good word here as these are not options,
i.e. users can't choose or set them. I see that 'dpdk' group uses
the same word, but we might need to change that as well. Some other
places use 'status information', for example.
I agree 'status information' sounds better. I'll update here and check
with Jaokb for dpdk as I don't want to cause unnecessary conflicts with
his patches.
+ </p>
+ <column name="status" key="mode">
+ Client or server vhost mode.
+ </column>
+ <column name="status" key="features">
+ vhost features bitmap.
+ </column>
+ <column name="status" key="num_of_vrings">
+ Number of vrings.
+ </column>
+ <column name="status" key="numa">
+ Vhost numa association.
+ </column>
+ <column name="status" key="socket">
+ Vhost socket path.
+ </column>
+ <column name="status" key="status">
+ Status of connection.
+ </column>
+ <column name="status" key="vring_n_size">
+ Size of vring n.
This is a very confusing description. Size of 'n'? :)
Most of other descriptions are also not very descriptive. I'm not
sure what is the value of adding these. I'd say we should either
document them better, so the average user can understand what they
mean, or just not describe at all.
What do you think?
Sure, I can expand them to be a bit more descriptive.
vring size is reported for a variable number of vrings, so there's
always going to be some correlation between the key and actual output
needed in that case, and I think with the output beside it, it makes
more sense. I can add some lines to state about there being variable of
vrings and what n is etc. to make it more clear standalone.
Thanks!
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
