On Mon, Oct 16, 2023 at 9:12 PM Ilya Maximets <i.maxim...@ovn.org> wrote:

> On 10/10/23 16:12, Ales Musil wrote:
> > The zone 0 is default system zone, do not use this
> > zone for the test because it might contain some
> > entries already which could cause flakiness during
> > the check.
> >
> > Signed-off-by: Ales Musil <amu...@redhat.com>
>
> Hi.  While this change makes sense, we're likeley loosing the
> coverage for zone=0 configuration.  Please add some tests for
> it to the unit-test suite that will ensure that we're parsing
> commands and interpret them correctly.
>
> Bets regards, Ilya Maximets.
>
>
Hi,
thank you for the review, it should be addressed in v5.

Thanks,
Ales

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA <https://www.redhat.com>

amu...@redhat.com
<https://red.ht/sig>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to