On Tue, Oct 17, 2023 at 07:11:19PM +0800, Zengyuan Wang via dev wrote:
> Variable "want_key" in function check_condition and variable "key" in
> function set_column were not destroyed in exception branch.
>
> This patch calls ovsdb_atom_destroy to release resources to avoid memory leak.
>
> Fixes: 79c1a00fb5a5 ("db-ctl-base: Don't die in set_column() on error.")
> Fixes: e09b3af3e249 ("db-ctl-base: Don't die in is_condition_satisfied() on
> error")
> Signed-off-by: Zengyuan Wang <wangzengy...@huawei.com>
Thanks,
I agree that there is a possible resource leak here.
I also agree that the problems seem to have been introduced
by the cited commits.
And I see that both of the cited patches were included in v2.10,
so any backporting can likely involve both fixes - else it might
have been better to split this into two patches.g
Overall, this looks good to me.
Acked-by: Simon Horman <ho...@ovn.org>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
