On 10/16/23 16:06, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 14:24, Eelco Chaudron wrote: > >> On 16 Oct 2023, at 14:22, David Marchand wrote: >> >>> On Fri, Oct 13, 2023 at 11:49 AM Eelco Chaudron <echau...@redhat.com> wrote: >>>>> The check-offloads target can run fine if removing the exception on >>>>> "failed to flow_get" and "failed to acquire ukey" warning logs. >>>> >>>> Would it be good to add another patch in the series, to remove these? >>>> >>> >>> Yes, I intend to send a followup patch if this patch gets merged. >> >> Thanks! > > > Just to clarify this. I did run the specific offload test with the below diff > 100x and it did not show the errors it was previously excluding. > > Cheers, > > Eelco > > diff --git a/tests/system-offloads-traffic.at > b/tests/system-offloads-traffic.at > index 7215e36e2..cf2a3c2e3 100644 > --- a/tests/system-offloads-traffic.at > +++ b/tests/system-offloads-traffic.at > @@ -799,8 +799,6 @@ AT_CHECK([test $(ovs-appctl dpctl/dump-flows | grep -c > "eth_type(0x0800)") -eq 0 > > OVS_TRAFFIC_VSWITCHD_STOP(["/could not open network device ovs-p0/d > /on nonexistent port/d > -/failed to flow_get/d > -/Failed to acquire udpif_key/d > /No such device/d > /failed to offload flow/d > "]) >
This change looks like it belongs to the current patch as it is a direct consequence of the change. Can we add it instead of posting separately? Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
