Hi Simon Horman, Thanks. If it's ready, I will repost again.
From: "Simon Horman"<[email protected]> Date: Tue, Oct 3, 2023, 16:50 Subject: [External] Re: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field To: <[email protected]> Cc: <[email protected]>, <[email protected]>, "Flavio Leitner"< [email protected]> On Mon, Sep 28, 2020 at 09:49:47PM +0800, [email protected] wrote: > From: "fankaixi.li" <[email protected]> > > In order to support openflow rule which setting nd_ext fields in openflow tables, > we should remove setting nd_ext fields when constructing rule. The ofproto would > translate it into userspace actions when handling upcalls. > > When trying to add the following flows to ovs with kernel: > # flow 1 > ovs-ofctl -Oopenflow13 add-flow br0 "cookie=0x4000000, table=0, > priority=50,icmp6,icmpv6_type=135,icmpv6_code=0,nd_target=2001:db8:0:2:0:0:0:1,nd_sll=fa:16:3e:55:ad:df,actions=set_field:136->icmpv6_type,set_field:0->icmpv6_code,set_field:2->nd_options_type,goto_table:1" > # flow 2 > ovs-ofctl -Oopenflow13 add-flow br0 "cookie=0x12220d57,table=1,priority=80,icmp6,icmpv6_type=136,icmpv6_code=0,nd_target=2001:db8:0:2:0:0:0:1,actions= move:eth_src[]->eth_dst[],set_field:00:23:15:d3:22:01->eth_src,move:ipv6_src[]->ipv6_dst[],set_field:2001:db8:0:2:0:0:0:1->ipv6_src,set_field:00:23:15:d3:22:01->nd_tll,set_field:0xe00->nd_reserved,set_field:2->nd_options_type,output:3" > > Ovs would emit a error message: > OFPT_ERROR (OF1.3) (xid=0x6): OFPBAC_BAD_SET_ARGUMENT > > The output of log file shows a error message: > 2020-09-28T12:22:09.453Z|00036|ofproto_dpif|WARN|Rejecting set field action because datapath does not support setting IPv6 ND Extensions fields (your kernel module may be out of date) > 2020-09-28T12:22:09.453Z|00037|connmgr|INFO|br0<->unix#14: sending OFPBAC_BAD_SET_ARGUMENT error reply to OFPT_FLOW_MOD message > > This patch would fix this error. > > Also following Flavio Leitner's advise, I have prepared a testcase for this patch. > But after running auto-testcases, I found that the test framework ovs support flows with actions to set nd_reserved field. > The testsuites.log shows table 0 supporting setting nd_reserved and nd_options_type fields, and it shows that ovs was configured at dummy mode. > I think there are some differences bewteen these two ovs modes. So I decide not commit the testcase about this fix. > > Signed-off-by: fankaixi.li <[email protected]> > CC: Flavio Leitner <[email protected]> > Fixes: d0d571493cf8 ("ofproto-dpif: Allow IPv6 ND Extensions only if supported") Hi Fankaixi Li, This patch appears to have gone stale in patchwork, for one reason or another. If it is still relevant then I think it needs to be revisited, by being reposted after appropriate preparation. As such I'm marking this patch as "Deferred" in patchwork. No action is required unless there is a desire to revisit this patch. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
