On 10/23/23 20:56, Jakob Meng wrote: > On 23.10.23 20:52, Jakob Meng wrote: >> On 23.10.23 15:31, Ilya Maximets wrote: >>> Since last month ReadTheDocs only supports building with a new >>> configuration file provided in the repository itself: >>> https://blog.readthedocs.com/migrate-configuration-v2/ >>> >>> So, all our documentation buids are failing for quite some time. >>> >>> Add the configuration file to unblock documentation updates. >>> >>> Need to remove the upper restriction on the sphinx version. >>> sphinx 2.0 is very old at this point and pip fails to install >>> it along with other dependencies on the rtd server. >>> >>> Note: Sphinx 2.0 moved from HTML4 to HTML5 renderer and tables >>> no longer have borders by default. That should be addressed >>> via CSS file in the ovs-sphinx-theme. >> It was initially limited to 2.0 for RHEL7 support [0]. Is this still >> relevant? >> >> [0] >> https://github.com/openvswitch/ovs/commit/59cf52e6d3307d5889335893fc941fe55cd3ed99 >> > > bs 🙄 This commit [1] introduced the 2.0 limit but its not clear why. > > [1] > https://github.com/openvswitch/ovs/commit/eeab45ffdc74325ba1aef893b1805e69867789da
The limit was set 2 years prior sphinx 2.0 release, so I'd say it was just a defensive measure for potential breaking changes in the future major release. It would be an equivalent of having <8.0 requirement today. Sphinx changed their release strategy to having one major release per year, so I'm not really sure if the limit like this makes much sense today. It's probably easier to just spot the breakage faster and fix it. We can always limit later if the breaking change will be too severe to fix right away. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
