On 10/18/23 09:56, Ales Musil wrote:
> Add optional argument to dpctl ct-del-limits called
> "default", which allows to remove the default limit
> making it effectively system default.
> 
> Signed-off-by: Ales Musil <amu...@redhat.com>
> ---
> v5: Rebase on top of current master.
>     Address comments from Ilya:
>     - Correct the NEWS entry.
>     - Fix style related problems.
> ---
>  NEWS                    |  3 +++
>  lib/dpctl.c             | 21 +++++++++++++++------
>  tests/system-traffic.at | 26 ++++++++++++++++++++++++++
>  3 files changed, 44 insertions(+), 6 deletions(-)

Hi, Ales.  Thanks for the patch!
It may need some extra changes in zone_limit_delete() though.
While removing a defualt zone it will now log zone '-1', which
is not particularly user-friendly.  Also, the second time we'll
try to remove the default limit the command will fail unable to
find the entry for the default zone.  It probably shouldn't fail,
because default zone limit is always there, even if unlimited.
We do always report a default value even if it wasn't configured.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to