On 10/26/23 09:39, Dexia Li via dev wrote:
>  For userspace datapath, this patch provides vxlan and geneve tunnel tso.
>  Only support userspace vxlan or geneve tunnel, meanwhile support
>  tunnel outter and inner csum offload. If netdev do not support offload
>  features, there is a software fallback.If netdev do not support vxlan
>  and geneve tso,packets will drop. Front-end devices can close offload
>  features by ethtool also.
> 
> Signed-off-by: Dexia Li <[email protected]>
> ---
>  lib/dp-packet.c         |  41 +++++++-
>  lib/dp-packet.h         | 216 ++++++++++++++++++++++++++++++++++++----
>  lib/dpif-netdev.c       |   4 +-
>  lib/flow.c              |   2 +-
>  lib/netdev-dpdk.c       |  88 ++++++++++++++--
>  lib/netdev-dummy.c      |   2 +-
>  lib/netdev-native-tnl.c | 106 ++++++++++++++++++--
>  lib/netdev-provider.h   |   4 +
>  lib/netdev.c            |  35 +++++--
>  lib/packets.c           |  12 +--
>  lib/packets.h           |   6 +-
>  tests/dpif-netdev.at    |   4 +-
>  12 files changed, 461 insertions(+), 59 deletions(-)

Hi, Dexia Li.  Thanks for working on this!

I didn't review the patch and I'm not sure if Mike will have more comments,
but the current version still breaks system tests.  You may see the report
from the Intel CI in patchwork.  It looks like packets are not delivered
anymore via ipv6 tunnels.

Also, you may run these tests yourself with (as root):

 # make check-system-userspace

It is the main testsuite that Intel CI is running.  You may also check:

 # make check-dpdk
 # make check-system-tso

These are the most relevant to your patch.

You may find some more information here:
  https://docs.openvswitch.org/en/latest/topics/testing/

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to