On Tue, Oct 31, 2023 at 10:29:47AM -0400, Mike Pattrick wrote:
> On Mon, Oct 30, 2023 at 7:43 AM Simon Horman <ho...@ovn.org> wrote:
> >
> > On Mon, Oct 30, 2023 at 02:58:36AM -0400, Mike Pattrick wrote:
> > > Currently when userspace-tso is enabled, netdev-linux interfaces will
> > > indicate support for all offload flags regardless of interface
> > > configuration. This patch checks for which offload features are enabled
> > > during netdev construction.
> > >
> > > Signed-off-by: Mike Pattrick <m...@redhat.com>
> >
> > ...
> >
> > > @@ -2381,6 +2376,153 @@ netdev_internal_get_stats(const struct netdev
> > > *netdev_,
> > > return error;
> > > }
> > >
> > > +static int
> > > +netdev_linux_read_stringset_info(struct netdev_linux *netdev, uint32_t
> > > *len)
> > > +{
> > > + /*
> > > + struct {
> > > + union {
> > > + struct ethtool_sset_info hdr;
> > > + struct {
> > > + uint64_t pad[2];
> > > + uint32_t sset_len[1];
> > > + };
> > > + };
> > > + } sset_info;
> > > + */
> >
> > Hi Mike,
> >
> > maybe the comment above is an artifact that should be removed?
>
> Hello Simon,
>
> Yes, that was some code mistakenly left in, sorry about that.
>
> Do you want me to resubmit the whole series now, or were you planning
> on taking a look at other patches in the series?
Hi Mike,
I think resubmitting now would be a good idea.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
