On Thu, Nov 02, 2023 at 02:56:41PM +0100, Eelco Chaudron wrote: > > > On 2 Nov 2023, at 13:59, Roi Dayan via dev wrote: > > > From: Eli Britstein <[email protected]> > > > > Fixes tag quotes another commit that might fail in a spell check. Don't > > fail it. > > > > Signed-off-by: Eli Britstein <[email protected]> > > Acked-by: Roi Dayan <[email protected]> > > --- > > utilities/checkpatch.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py > > index a56f429d4c38..6b210fab8385 100755 > > --- a/utilities/checkpatch.py > > +++ b/utilities/checkpatch.py > > @@ -409,6 +409,9 @@ def check_spelling(line, comment): > > if not spell_check_dict or not spellcheck: > > return False > > > > + if line.startswith('Fixes: '): > > + return False > > My initial thought was, should we not match it more precisely with something > like is_fixes_exact? But it seems like not an issue as using “Fixes: “ to > summarize stuff would fail anyway. > > So this looks good to me! > > Acked-by: Eelco Chaudron <[email protected]> > > I guess who ever commits this patch can add the . at the end of the subject.
Thanks, applied with a '.' appended to the subject. - checkpatch: Don't spell check Fixes tag. https://github.com/openvswitch/ovs/commit/bf843fd439b2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
