On 03.11.23 22:44, Ilya Maximets wrote: > On 10/30/23 10:49, [email protected] wrote: >> From: Jakob Meng <[email protected]> >> >> For better usability, the function pairs get_config() and >> set_config() for netdevs should be symmetric: Options which are >> accepted by set_config() should be returned by get_config() and the >> latter should output valid options for set_config() only. This patch >> also moves key-value pairs which are no valid options from get_config() >> to the get_status() callback. >> >> ... >> >> --- a/vswitchd/vswitch.xml >> +++ b/vswitchd/vswitch.xml >> @@ -3821,6 +3821,17 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 >> type=patch options:peer=p1 \ >> supported by hardware. >> </column> >> </group> >> + >> + <group title="afxdp"> >> + <p> >> + AF_XDP netdev specific interface status options. > 'netdev' word seems redundant here. 'netdev' and 'interface' are > basically words that describe the same thing in this context. > And the 'interface' should be preferred in the user documentation, > as that is the entity users actually interact with via database. > >> + </p> >> + >> + <column name="status" key="xdp-mode"> >> + XDP mode which was chosen. > The "was chosen" here is a bit ambiguous as it may be interpreted > as both "chosen by the user" and "chosen by OVS itself". > "currently in use" might be a better way to describe the meaning, > as it kind of was before. > > It might also be useful to reference the <ref column="options" > key="xdp-mode" /> for the description of the possible values. > >> + </column> >> + >> + </group> >> </group> >> >> <group title="Statistics">
ack, ty, integrated into patch series v8: https://patchwork.ozlabs.org/project/openvswitch/list/?series=381909 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
