On 11/13/23 14:33, Dumitru Ceara wrote: > Without this, when using Python 3.12 and flake8 5.0.4, the following > errors are flagged: > tests/check_acl_log.py:97:25: E231 missing whitespace after ':' > tests/check_acl_log.py:102:71: E231 missing whitespace after ':' > > This was reported and discussed in a couple of contexts: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409325.html > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409277.html > > And it's fixed in recent flake8/pycodestyle versions: > https://github.com/PyCQA/flake8/issues/1845#issuecomment-1766073353 > > Unfortunately we have to remove the 'hacking' requirement because that > introduces a dependency on 'flake8<4.0.0 and >=3.6.0'. That should be > OK though because 'hacking' is an OpenStack specific package and OVN > doesn't expose any Python code. > > Signed-off-by: Dumitru Ceara <[email protected]> > --- > NOTE: this patch should be backported to all supported branches. > --- > utilities/containers/py-requirements.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/utilities/containers/py-requirements.txt > b/utilities/containers/py-requirements.txt > index 0d90765c97..a8e8f17da3 100644 > --- a/utilities/containers/py-requirements.txt > +++ b/utilities/containers/py-requirements.txt > @@ -1,7 +1,7 @@ > -flake8 > -hacking>=3.0 > +flake8>=6.1.0 > scapy > sphinx > setuptools > pyelftools > pyOpenSSL > +pycodestyle>=2.11.0
Alternative might be to still install hacking for python <3.12, but do not otherwise. See https://peps.python.org/pep-0508/#environment-markers Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
