On Tue, Oct 31, 2023 at 03:51:37PM -0400, Mike Pattrick wrote:
> From: Flavio Leitner <[email protected]>
>
> Currently OVS will calculate the segment size based on the
> MTU of the egress port. That usually happens to be correct
> when the ports share the same MTU, but that is not always true.
>
> Therefore, if the segment size is provided, then use that and
> make sure the over sized packets are dropped.
>
> Signed-off-by: Flavio Leitner <[email protected]>
> Co-authored-by: Mike Pattrick <[email protected]>
> Signed-off-by: Mike Pattrick <[email protected]>
...
> diff --git a/lib/dp-packet.h b/lib/dp-packet.h
> index 70ddf8aa4..6a924f3ff 100644
> --- a/lib/dp-packet.h
> +++ b/lib/dp-packet.h
> @@ -126,6 +126,7 @@ struct dp_packet {
> uint32_t ol_flags; /* Offloading flags. */
> uint32_t rss_hash; /* Packet hash. */
> uint32_t flow_mark; /* Packet flow mark. */
> + uint16_t tso_segsz; /* TCP TSO segment size. */
Hi Mike,
I don't think there is any need to respin just because of this,
but in my view "TCP TSO" is a tautology. This is because, AFAIK,
the T in TSO stands for TCP.
The above notwithstanding this patch looks good to me.
Acked-by: Simon Horman <[email protected]>
...
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
