On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara <[email protected]> wrote:

> We're sending TCP RST not RST-ACK as the comment suggests.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html
> Reported-by: Mark Michelson <[email protected]>
> Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for lb hc")
> Signed-off-by: Dumitru Ceara <[email protected]>
> ---
>  controller/pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 62cf4da324..1b176490ea 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn,
>          svc_mon->n_success++;
>          svc_mon->state = SVC_MON_S_ONLINE;
>
> -        /* Send RST-ACK packet. */
> +        /* Send RST packet. */
>          svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST,
>                                              htonl(tcp_ack),
>                                              htonl(0), th->tcp_dst);
> --
> 2.39.3
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.

Acked-by: Ales Musil <[email protected]>

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA <https://www.redhat.com>

[email protected]
<https://red.ht/sig>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to