On 12/4/23 16:24, Eelco Chaudron wrote:
> 
> 
> On 1 Dec 2023, at 22:04, Ilya Maximets wrote:
> 
>> If a packet is received from a UDP tunnel, it has a source port
>> populated in the tunnel metadata.  This field cannot be read or
>> changed with OpenFlow or the tunnel configuration.  However, while
>> sending this packet to a different tunnel, the value remains in
>> the metadata and is being sent to the datapath to use as a source
>> port for this new tunnel.  Tunnel implementations largely ignore
>> this value, and it is a random value from a different tunnel
>> anyway.
>>
>> Clear it while sending to a different tunnel, so the unnecessary
>> information is not being passed to the datapath.  This additionally
>> allows traffic from one tunnel to anther to be offloaded to TC,
>> as TC doesn't allow setting the source port at all.
>>
>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>
>> ---
> 
> I tested this patch on multiple datapath configurations, and it all seems to 
> pass.
> 
> Thanks for looking into this, and adding the test case.
> 
> //Eelco
> 
> Acked-by: Eelco Chaudron <echau...@redhat.com>
> 


Thanks, Eelco and Valdislav!

Applied.  This one is on the edge between a bug fix and enhancement,
but it seems to be low risk, so I backported it down to 2.17 as well.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to