On 12/18/23 10:52, Dumitru Ceara wrote: > On 12/16/23 04:48, [email protected] wrote: >> From: Numan Siddique <[email protected]> >> >> This reverts commit 450e41e783bfa69e4f9d6c80f6bcb01147d5cfe1. >> >> If a packet has to be tunnelled to another node and if the physical >> interface used for tunnelling has lower MTU than the packet or >> if there is a route exception with a lower MTU, then the geneve >> kernel module generates an ICMP need frag packet. This packet >> was getting dropped since the metadata had to be swapped. >> The commit [1] did exactly that and fixed the issue. >> But it has 2 issues - >> 1. It introduced a regression for the scenario when an ICMP need frag >> packet generated outside of OVN has to be tunnelled and delivered >> to the destination VM/pod. These ICMP need frag packets are now >> dropped. >> 2. If the logical switches has ACLs or load balancers configured then >> these icmp need frag packets are dropped as they are not sent to >> the correct zone. >> >> Its better to revert until we find a proper solution for the original >> issue. > > I agree, it sounds good to me. > >> >> [1] - 450e41e783bf("ovn: add geneve PMTUD support") > > This should actually be: > > Fixes: 450e41e783bf ("ovn: add geneve PMTUD support") > > With that fixed up: > Acked-by: Dumitru Ceara <[email protected]> >
I forgot, sorry. To simplify our downstream process it would be great if you could add: Reported-at: https://issues.redhat.com/browse/FDP-216 Thanks again! >> >> Signed-off-by: Numan Siddique <[email protected]> >> --- _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
