On 1/8/24 17:59, Frode Nordahl wrote: > Hello, Ilya and OVS developers, > > On Wed, Jan 3, 2024 at 12:59 AM Ilya Maximets <[email protected]> wrote: >> >> Hi. As described in Documentation/internals/release-process.rst, we are >> in a "soft freeze" state: >> >> During the freeze, we ask committers to refrain from applying patches that >> add new features unless those patches were already being publicly >> discussed >> and reviewed before the freeze began. Bug fixes are welcome at any time. >> Please propose and discuss exceptions on ovs-dev. >> >> As far as I can tell, most of the active patches currently on the mailing >> list were already reviewed to some extent, so they do qualify for being >> accepted during the soft freeze (potentially with some changes made in the >> additional review rounds). We do also await new versions for several patches >> and patch sets for which changes were requested. These, of course, can be >> accepted as well. >> >> If there are some new patches that never been reviewed / not posted yet, >> please, propose an exception in reply to this email and it can be discussed. > > On the back of your review feedback in [0] I've been working on an > implementation of a cooperative multitasking module for use in OVSDB. > The goal of the work is to improve OVSDB's ability to maintain RAFT > cluster communication even when it is performing long running tasks > such as database schema conversion, processing of monitors and > similar. I hereby request a freeze exception for this work. > > I have posted a RFC with the current state of the work [1], it is > posted as RFC because I am still in a close loop with testing to close > some cases where the time threshold is still overrun. I'll hopefully > figure out the remaining places we need to yield to avoid these and > then post a formal patch series with documented testing. > > 0: https://mail.openvswitch.org/pipermail/ovs-dev/2023-December/410262.html > 1: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410593.html >
Hi, Frode. I think it's fine to get this during a soft freeze as the code seems to not be overly complex and it was discussed a few times before. Though, on a quick glance, I think that [1] takes a little bit of a scattershot approach to the problem in terms of yielding seemingly in way too many places, but that, I'm sure, can be sorted out during a review process. I'll take a closer look later this week. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
