On Wed, Jan 17, 2024 at 06:56:31PM +0000, Simon Horman wrote: > On Wed, Jan 17, 2024 at 01:55:36PM +0100, [email protected] wrote: > > From: Jakob Meng <[email protected]> > > > > Previous commits introduced support different output formats to > > ovs-xxx tools and its Python equivalents. However, the commands > > were not yet migrated to the updated {unixctl_}command_register() > > functions and unixctl_cb_func function type in order to highlight > > the API changes only. > > > > This patch accomplishes this command migration in a single sweep. > > It replaces the old functions {unixctl_}command_register() in > > lib/unixctl.* and python/ovs/unixctl/__init__.py with their > > extended variants featuring the new 'output_fmts' parameter. > > All command registrations have been updated to announce what output > > formats each commands supports. No new output formats have been > > added, i.e. all commands still support OVS_OUTPUT_FMT_TEXT only. > > > > All command callbacks gained a 'enum ovs_output_fmt fmt OVS_UNUSED' > > argument to conform with the updated function type unixctl_cb_func > > in lib/unixctl.h. Without any new output formats being added, it is > > always ignored for now. > > > > Reported-at: https://bugzilla.redhat.com/1824861 > > Signed-off-by: Jakob Meng <[email protected]> > > Recheck-request: github-robot
Hi Jacob, Recheck triggered 2nd run of jobs. However, both the 1st and 2nd runs failed. e.g. 184: IPsec -- Libreswan (ipv4, geneve, defaultroute, psk) FAILED (ovs-macros.at:242) 185: IPsec -- Libreswan (ipv4, geneve, localip, psk) FAILED (ovs-macros.at:242) 186: IPsec -- Libreswan (ipv4, geneve, defaultroute, self-signed) FAILED (ovs-macros.at:242) 187: IPsec -- Libreswan (ipv4, geneve, defaultroute, ca-signed) FAILED (ovs-macros.at:242) 188: IPsec -- Libreswan (ipv4, gre, defaultroute, psk) FAILED (ovs-macros.at:242) 189: IPsec -- Libreswan (ipv4, vxlan, defaultroute, psk) FAILED (ovs-macros.at:242) 190: IPsec -- Libreswan (ipv6, vxlan, defaultroute, psk) FAILED (ovs-macros.at:242) 191: IPsec -- Libreswan (ipv6, vxlan, localip, psk) FAILED (ovs-macros.at:242) 192: IPsec -- Libreswan (ipv6, geneve, defaultroute, psk) FAILED (ovs-macros.at:242)o https://github.com/ovsrobot/ovs/actions/runs/7556373167/job/20587597728 Ilya tells me he think this is because the ovs-monitor-ipsec script needs to be updated for the new API. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
