On 1/18/24 22:39, Numan Siddique wrote:
>>> +void
>>> +ovn_dp_groups_clear(struct hmap *dp_groups)
>>> +{
>>> +    struct ovn_dp_group *dpg;
>>> +    HMAP_FOR_EACH_POP (dpg, node, dp_groups) {
>>> +        bitmap_free(dpg->bitmap);
>>> +        free(dpg);
>> This is duplicated in dec_ovn_dp_group_ref().  Also, should we assert
>> that all refcounts are 0 here?
> I don't think we can.  Since ovn_dp_groups_clear() will be called
> whenever a full recompute
> happens.  In this case,  we are destroying the internal data and
> rebuilding and the ref count may not be 0.

Hmm, OK, I think that might be fine.

Thanks for checking.

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to