On Tue, Jan 23, 2024 at 4:10 PM Dumitru Ceara <dce...@redhat.com> wrote:
> On 1/23/24 14:58, Mohammad Heib wrote:
> >>> static struct pinctrl pinctrl;
> >>> @@ -3586,11 +3587,21 @@ pinctrl_update(const struct ovsdb_idl *idl,
> >> const char *br_int_name)
> >>> if (dns_supports_ovn_owned != pinctrl.dns_supports_ovn_owned) {
> >>> pinctrl.dns_supports_ovn_owned = dns_supports_ovn_owned;
> >>>
> >>> - /* Notify pinctrl_handler that fdb timestamp column
> >>> + /* Notify pinctrl_handler that dns ovn_owned column
> >>> * availability has changed. */
> >>> notify_pinctrl_handler();
> >>> }
> >>>
> >>> + bool igmp_support_proto =
> >>> + sbrec_server_has_igmp_group_table_col_protocol(idl);
> >>> + if (igmp_support_proto != pinctrl.igmp_support_protocol) {
> >>> + pinctrl.igmp_support_protocol = igmp_support_proto;
> >> We only use this in the main thread, when updating the SB, why can't we
> >> just directly check the column support there instead?
> >>
> > *like you mean to call
> > sbrec_server_has_igmp_group_table_col_protocol(idl); inside the
> **ip_mcast_sync
> > function?*
> > *something like this:*
> >
> >
> >
> >
> > * /* Set Group protocol*/ if
> > (sbrec_server_has_igmp_group_table_col_protocol(idl)) {
> > igmp_group_set_protocol(sbrec_igmp,
> > mc_group->protocol_version); }*
>
> Yes, I think that would be better. Or even inside
> igmp_group_update_ports() but then we should also pass the IDL pointer;
> the latter seems like a better option to me.
>
> Please let me know what you think.
>
Sound good to me :),
i will send v2 addressing your comments when I can bump the ovs to the last
stable.
Thank you so much :)
>
> Regards,
> Dumitru
>
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
