On 1/24/24 22:59, Numan Siddique wrote:
> On Fri, Jan 19, 2024 at 6:57 AM Dumitru Ceara <[email protected]> wrote:
>>
>> On 1/11/24 16:33, [email protected] wrote:
>>> From: Numan Siddique <[email protected]>
>>>
>>> Signed-off-by: Numan Siddique <[email protected]>
>>> ---
>>
>> Hi Numan,
>>
>>> diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c
>>> index dcce79510a..f7c3d2bcf5 100644
>>> --- a/northd/inc-proc-northd.c
>>> +++ b/northd/inc-proc-northd.c
>>> @@ -228,11 +228,11 @@ void inc_proc_northd_init(struct ovsdb_idl_loop *nb,
>>>      engine_add_input(&en_lflow, &en_sb_logical_flow, NULL);
>>>      engine_add_input(&en_lflow, &en_sb_multicast_group, NULL);
>>>      engine_add_input(&en_lflow, &en_sb_igmp_group, NULL);
>>> -    engine_add_input(&en_lflow, &en_ls_stateful, NULL);
>>>      engine_add_input(&en_lflow, &en_sb_logical_dp_group, NULL);
>>>      engine_add_input(&en_lflow, &en_northd, lflow_northd_handler);
>>>      engine_add_input(&en_lflow, &en_port_group, lflow_port_group_handler);
>>>      engine_add_input(&en_lflow, &en_lr_stateful, 
>>> lflow_lr_stateful_handler);
>>> +    engine_add_input(&en_lflow, &en_ls_stateful, 
>>> lflow_ls_stateful_handler);
>>>
>>>      engine_add_input(&en_sync_to_sb_addr_set, &en_nb_address_set,
>>>                       sync_to_sb_addr_set_nb_address_set_handler);
>>> diff --git a/northd/lflow-mgr.c b/northd/lflow-mgr.c
>>> index 6cb2a367fe..d81b13a25c 100644
>>> --- a/northd/lflow-mgr.c
>>> +++ b/northd/lflow-mgr.c
>>> @@ -442,7 +442,7 @@ lflow_ref_unlink_lflows(struct lflow_ref *lflow_ref)
>>>              BITMAP_FOR_EACH_1 (index, lrn->dpgrp_bitmap_len,
>>>                                 lrn->dpgrp_bitmap) {
>>>                  if (dec_dp_refcnt(&lrn->lflow->dp_refcnts_map, index)) {
>>> -                    bitmap_set0(lrn->lflow->dpg_bitmap, lrn->dp_index);
>>> +                    bitmap_set0(lrn->lflow->dpg_bitmap, index);
>>
>> Hmm, is this something that should go in "[PATCH ovn v5 01/16] northd:
>> Refactor the northd change tracking."?
> 
> I guess you mean patch 11 "northd: Handle lb changes in lflow engine.".
> If so, that's correct.  I'll fix it in v6.

Yes, you're right, sorry about that.

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to