On 1/25/24 22:46, Mike Pattrick wrote:
> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
> a BFD packet flagged as double encapsulated would trigger a seg fault.
> The problem surfaced because bfd_put_packet was reusing a packet
> allocated on the stack that wasn't having its flags reset between calls.
>
> This change will reset OL flags as well as the layer offsets in
> data_clear(), which should fix this type of packet reuse issue in
> general as long as data_clear() is called in between uses.
>
> Fixes: 8b5fe2dc6080 ("userspace: Add Generic Segmentation Offloading.")
> Reported-by: Dumitru Ceara <[email protected]>
> Reported-at: https://issues.redhat.com/browse/FDP-300
> Signed-off-by: Mike Pattrick <[email protected]>
> ---
Thanks, Mike! This patch seems correct to me and it fixes the issue
with OVN in my testing.
Applied this one and backported to 3.3.
I left some comments for the other patches in the set.
FWIW, Dumitru, you may want to wait for the following change to land
before upgrading submodule in OVN:
https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
