On 1/30/24 10:48, Mohammad Heib wrote: > Hi, > Thank you Dumitru. > > Acked-by: Mohammad Heib <[email protected]> > > On Tue, Jan 30, 2024 at 11:16 AM Eelco Chaudron <[email protected]> wrote: > >> >> >> On 30 Jan 2024, at 9:57, Dumitru Ceara wrote: >> >>> On 1/30/24 09:04, Eelco Chaudron wrote: >>>> >>>> >>>> On 30 Jan 2024, at 0:36, Dumitru Ceara wrote: >>>> >>>>> This picks up the following relevant OVS commits: >>>>> 8893e24d9d dpdk: Update to use v23.11. >>>>> ed738eca39 util: Annotate function that will never return NULL. >>>>> 77d0bad04 mcast-snooping: Store IGMP/MLD protocol version. >>>>> b222593bc6 mcast-snooping: Add group protocol to mdb/show output. >>>>> a940a691e7 ovs-atomic: Fix inclusion of Clang header by GCC 14. >>>>> b0cf73112d dp-packet: Reset offload/offsets when clearing a packet. >>>>> >>>>> This commit also ports the CI DPDK related changes from OVS commit >>>>> 8893e24d9d09 ("dpdk: Update to use v23.11.") which are required as >> 23.11 >>>>> is the supported DPDK branch on OVS 3.3. There's also a small change >>>>> that had to be made when mangling the prefix path of the installed >>>>> DPDK version in the container. >>>>> >>>>> As a side effect this will also address OVN Fedora 40 (rawhide) build >>>>> failures on aarch64 and s390x. They are fixed by a940a691e7d9 >>>>> ("ovs-atomic: Fix inclusion of Clang header by GCC 14."). >>>>> >>>>> Suggested-by: Ilya Maximets <[email protected]> >>>>> Signed-off-by: Dumitru Ceara <[email protected]> >>>> >>>> There is also a change in controller/pinctrl.c, any reason why this is >> part of this patch? >>>> >>> >>> Yes, b222593bc6 ("mcast-snooping: Add group protocol to mdb/show >>> output") changed the OVS mcast library API. That's used by OVN. We >>> need that pinctrl.c change otherwise compilation fails. >> >> Thanks Dumitru for the clarification, maybe you can add this to the commit >> message when you apply? The rest looks good, and as the tests passed; >> >> Acked-by: Eelco Chaudron <[email protected]> >>
Thanks, Numan, Eelco and Mohammad for the reviews! I updated the commit log to reflect the pinctrl.c change too and pushed this to the main branch. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
