On Tue, Feb 06, 2024 at 11:15:24AM -0500, Mike Pattrick wrote:
> Include inner offsets in functions where l3 and l4 offsets are either
> modified or checked.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Mike Pattrick <[email protected]>
...
> diff --git a/lib/odp-execute-avx512.c b/lib/odp-execute-avx512.c
> index 747e04014..4a3396fbd 100644
> --- a/lib/odp-execute-avx512.c
> +++ b/lib/odp-execute-avx512.c
> @@ -35,10 +35,10 @@
>
> VLOG_DEFINE_THIS_MODULE(odp_execute_avx512);
>
> -/* The below three build asserts make sure that l2_5_ofs, l3_ofs, and l4_ofs
> - * fields remain in the same order and offset to l2_padd_size. This is needed
> - * as the avx512_dp_packet_resize_l2() function will manipulate those fields
> at
> - * a fixed memory index based on the l2_padd_size offset. */
> +/* The below three build asserts make sure that the below fields remain in
> the
nit: As pointed out by David in his review of v2,
there are no longer three asserts.
> + * same order and offset to l2_pad_size. This is needed as the
> + * avx512_dp_packet_resize_l2() function will manipulate those fields at a
> + * fixed memory index based on the l2_pad_size offset. */
> BUILD_ASSERT_DECL(offsetof(struct dp_packet, l2_pad_size) +
> MEMBER_SIZEOF(struct dp_packet, l2_pad_size) ==
> offsetof(struct dp_packet, l2_5_ofs));
...
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
