On 2/20/24 23:33, Alin Serdean wrote: > Thank you so much for the patches and dealing with this, Ilya! > > Regarding the MD / MT linking for a given binary, this can work, usually, > without any issues, although it will increase the memory used by the process > because both runtimes have to be loaded. > > We are linking the rest of the binaries with MT / MTd inside OVS: > https://github.com/openvswitch/ovs/blob/master/build-aux/cccl#L92-L98 > <https://github.com/openvswitch/ovs/blob/master/build-aux/cccl#L92-L98> . > Can you please change the OpenSSL to link with MT instead of MD?
Ah, good point, I wasn't aware that we're linking other stuff with MT. Sure, I can change that. Should I send a v2 with this change? > This will ensure that we test with what will be built in the end. > > Because we are changing the defaults to msys2 / openssl3 we need to also > update the documentation. > > I'm okay with changing it to a later date. If you prefer, I can pick this one > up. Looking at the links below I'm actually not sure what should be changed there beside replacing OpenSSL-Win32 with OpenSSL-Win64. I suppose we need to change the instructions at the top from MinGW to MSYS, but I actually have no idea how to install them. I've only been using what AppVeyor provides. :) So, if you can take this one that would be great. It can definitely be a separate change. Best regards, Ilya Maximets. > > I will insert the snippets where the documentation has to be changed for > OpenSSL: > https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L109-L115 > > <https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L109-L115> > https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L179-L185 > > <https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L179-L185> > https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L191-L199 > > <https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/windows.rst?plain=1#L191-L199> > > > Alin. > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *From:* dev <[email protected]> on behalf of Simon Horman > <[email protected]> > *Sent:* Thursday, February 15, 2024 2:08 PM > *To:* Ilya Maximets <[email protected]> > *Cc:* [email protected] <[email protected]> > *Subject:* Re: [ovs-dev] [PATCH 3/4] m4: Fix linking with OpenSSL 1.1.0+ and > 3+ on Windows. > > On Tue, Feb 13, 2024 at 08:40:17PM +0100, Ilya Maximets wrote: >> OpenSSL 1.1.0 changed the library names from libeay32 and ssleay32 to >> standard libssl and libcrypto. All the versions of OpenSSL that used >> old names reached their official EoL, so it should be safe to just >> migrate to new names. They can still be supported via premium support >> option, but I don't think that is important for us. >> >> Also, OpenSSL installers for older versions had the following folder >> structure: > > ... > >> Basically, instead of one generic library in the lib folder and a bunch >> of differently named versions of it for different type of linkage, we >> now have multiple instances of the library located in different folders >> based on the linkage type. So, we have to provide an exact path in >> order to find the library. >> >> 'lib/VC/x64/MD' was chosen in this patch and it seems to work fine. >> MD stands for dynamic linking, MT is static, 'd' stands for debug >> versions of the libraries. >> >> Signed-off-by: Ilya Maximets <[email protected]> > > Acked-by: Simon Horman <[email protected]> > > ... > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > <https://mail.openvswitch.org/mailman/listinfo/ovs-dev> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
