+ Xavier
On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote:
> Ilya Maximets <[email protected]> writes:
>
> > On 8/31/23 09:15, Frode Nordahl wrote:
> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio <[email protected]> wrote:
> >>>
> >>> From: hepeng <[email protected]>
> >>>
> >>> The patch avoids the extra allocation for nat_conn.
> >>> Currently, when doing NAT, the userspace conntrack will use an extra
> >>> conn for the two directions in a flow. However, each conn has actually
> >>> the two keys for both orig and rev directions. This patch introduces a
> >>> key_node[CT_DIRS] member as per Aaron's suggestion in the conn which
> >>> consists of a key, direction, and a cmap_node for hash lookup so
> >>> addressing the feedback received by the original patch [0].
> >>>
> >>> [0]
> >>> https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
> >>>
> >>> Signed-off-by: Peng He <[email protected]>
> >>> Co-authored-by: Paolo Valerio <[email protected]>
> >>> Signed-off-by: Paolo Valerio <[email protected]>
> >>
> >> Thanks alot for working on this, should we perhaps reference the
> >> original bug report, i.e:
> >> Reported-by: Michael Plato <[email protected]>
> >> Reported-at:
> >> https://mail.openvswitch.org/pipermail/ovs-discuss/2022-September/052065.html
> >
> > Can be added while applying, I think. It also may be worth adding
> > a sentence about fixing the assertion to the commit message.
>
> Done.
>
> >>
> >> We have a reproducer for the issue and we no longer see it occurring
> >> with this patch.
> >> Tested-by: Frode Nordahl <[email protected]>
> >
> > Thanks!
>
> Thanks everyone! I've applied and backported down to branch-3.0, and
> will work on the backport to branch-2.17.
Hi Aaron,
while working on [1] I notice that this patch did not seem to be
backported to branch-3.2. I will plan on doing so as part of
my backports of [1].
[1] [ovs-dev,v3] conntrack: Fix flush not flushing all elements.
https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
