On 3/7/24 20:09, Ilya Maximets wrote:
> On 3/7/24 18:08, Eric Garver wrote:
>> v10:
>>   - fix a sparse error in show_dp_feature_atomic_bool()
>> v9:
>>   - new patch make get_datapath_cap() access support by pointer
>>   - fix a clang warning in copy_support()
>> v8:
>>   - new patch to support atomic_bool dpif field types
>>   - re-add re-probe of support
>>   - use atomic_bool type for explicit_drop_action
>> v7:
>>   - remove re-probe of support as Ilya is working on a generic solution
>> v6:
>>   - improve log if hw-offload enabled
>>   - re-probe support if hw-offload set true at runtime
>> v5:
>>   - combine patches 3 and 4
>>   - add description to combined patch 3
>> v4:
>>   - avoid passing action to datapath if TC offload in use
>> v3:
>>   - alter test such that it's reliable, different xlate_error
>>   - better commit message in patch 2
>>   - reordered _DEC_TTL value in switch statements
>>   - add format_dec_ttl_action()
>> v2:
>>   - new patch (1) to fix build (switch cases)
>>   - fixed check-system-userspace
>>
>> Eric Garver (5):
>>   dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.
>>   dpif: Make get_datapath_cap() access support by pointer.
>>   dpif: Support atomic_bool field type.
>>   dpif: Probe support for OVS_ACTION_ATTR_DROP.
>>   tests: system-traffic: Add coverage for drop action.
>>
>>  include/linux/openvswitch.h   |   3 +-
>>  lib/dpif-netdev.c             |   1 +
>>  lib/dpif.c                    |   7 +-
>>  lib/dpif.h                    |   1 -
>>  lib/odp-execute.c             |   2 +
>>  lib/odp-util.c                |  23 ++++
>>  ofproto/ofproto-dpif-ipfix.c  |   1 +
>>  ofproto/ofproto-dpif-sflow.c  |   1 +
>>  ofproto/ofproto-dpif.c        | 198 +++++++++++++++++++++++++++-------
>>  ofproto/ofproto-dpif.h        |   4 +-
>>  tests/system-common-macros.at |   4 +
>>  tests/system-traffic.at       |  31 ++++++
>>  12 files changed, 227 insertions(+), 49 deletions(-)
>>
> 
> 
> Hi, Eric.  There are still issues with the unused function in the
> second patch and some issue with clang-analyzer in the next one.

Actually, clang-analyzer just fails to build due to the same unused
function.

> 
> In general, it might be easier if you can debug the tests by pushing
> to you local fork on github first before sending patches to the list.
> Just to save a few iterations.
> 
> Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to